Repository navigation
fix(parser): keep lifecycle and replication event data in S3RecordModel - #8819
Conversation
|
Thanks a lot for your first contribution! Please check out our contributing guidelines and don't hesitate to ask whatever you need. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #8819 +/- ##
========================================
Coverage 97.14% 97.14%
========================================
Files 327 327
Lines 16790 16802 +12
Branches 1538 1538
========================================
+ Hits 16311 16323 +12
Misses 336 336
Partials 143 143 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
heyy @leandrodamascena pls review my pr and approve it. thanks!! |
Manishram-ai
left a comment
There was a problem hiding this comment.
Thanks for picking this up. I compared the new models with the replication sample in the S3 docs, and all five fields line up. The example values for s3Operation and failureReason don't match what S3 sends, though, since the sample has codes there (OBJECT_PUT and AssumeRoleNotPermitted). I left suggestions for the examples and the fixture, and the parser tests (273), ruff and mypy pass with them.
|
Thanks @Manishram-ai for catching that, all four suggestions are applied now. The s3Operation and failureReason examples use the real S3 codes now, OBJECT_PUT and AssumeRoleNotPermitted, in the model examples, the record example, and the fixture. Parser tests, ruff and mypy all pass with them. Could you take another look when you get a chance? |
Manishram-ai
left a comment
There was a problem hiding this comment.
Thanks for the quick update! The examples and the fixture match the S3 sample now, and the parser tests pass for me on the new commit.
|
Thanks @Manishram-ai for the review! If anything needs any changes or updates, please let me know. Looking forward to getting this approved. Thanks! |
leandrodamascena
left a comment
There was a problem hiding this comment.
Thanks @dropps07! Keeping every replication field optional is the right call, AWS only documents that payload for failed replications, and the models line up one to one with what we ship in the TypeScript parser. New fixture instead of touching the existing one, exactly as we ask. Goes out in 3.42.0, no need to rebase, you'll be in the release notes.
superb! |
|
|
Awesome work, congrats on your first merged pull request and thank you for helping improve everyone's experience! |
|
Awesome work, congrats on your first merged pull request and thank you for helping improve everyone's experience! |



Issue number: closes #8800
Summary
Changes
S3RecordModel drops lifecycleEventData and replicationEventData from S3 events. Pydantic silently discards undeclared keys, so the parser loses both fields even though S3 sends them. Added three typed models for the lifecycle and replication event data, added lifecycleEventData and replicationEventData fields to S3RecordModel, added a replication event fixture and a new replication test plus lifecycle assertions.
User experience
Before: parsing an S3 event with lifecycle or replication data silently dropped those fields, so event objects had no access to them. After: both fields are preserved on the parsed S3 record.
Verification
I ran the S3 parser tests, the full parser unit suite and the functional parser tests and they all pass, with ruff and mypy clean. Negative control: both new tests fail without the fix. This PR was prepared with the assistance of an AI coding assistant, and the verification above was done by me.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.