Skip to content

fix(parser): keep lifecycle and replication event data in S3RecordModel - #8819

Merged
leandrodamascena merged 4 commits into
aws-powertools:developfrom
dropps07:fix/8800-s3-record-model
Nov 20, 2026
Merged

leandrodamascena merged 4 commits into
aws-powertools:developfrom
dropps07:fix/8800-s3-record-model

Conversation

@dropps07

@dropps07 dropps07 commented Nov 15, 2026 •

Copy link
Copy Markdown
Contributor

Issue number: closes #8800

Summary

Changes
S3RecordModel drops lifecycleEventData and replicationEventData from S3 events. Pydantic silently discards undeclared keys, so the parser loses both fields even though S3 sends them. Added three typed models for the lifecycle and replication event data, added lifecycleEventData and replicationEventData fields to S3RecordModel, added a replication event fixture and a new replication test plus lifecycle assertions.

User experience
Before: parsing an S3 event with lifecycle or replication data silently dropped those fields, so event objects had no access to them. After: both fields are preserved on the parsed S3 record.

Verification
I ran the S3 parser tests, the full parser unit suite and the functional parser tests and they all pass, with ruff and mypy clean. Negative control: both new tests fail without the fix. This PR was prepared with the assistance of an AI coding assistant, and the verification above was done by me.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.

@dropps07
dropps07 requested a review from a team as a code owner November 15, 2026 14:08
@boring-cyborg

boring-cyborg Bot commented Nov 15, 2026

Copy link
Copy Markdown

Thanks a lot for your first contribution! Please check out our contributing guidelines and don't hesitate to ask whatever you need.
In the meantime, check out the #python channel on our Powertools for AWS Lambda Discord: Invite link

@powertools-for-aws-oss-automation powertools-for-aws-oss-automation Bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Nov 15, 2026
@boring-cyborg boring-cyborg Bot added the tests label Nov 15, 2026
@codecov

codecov Bot commented Nov 15, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.14%. Comparing base (a4eb1ff) to head (694d6cd).
⚠️ Report is 1 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #8819   +/-   ##
========================================
  Coverage    97.14%   97.14%           
========================================
  Files          327      327           
  Lines        16790    16802   +12     
  Branches      1538     1538           
========================================
+ Hits         16311    16323   +12     
  Misses         336      336           
  Partials       143      143           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dropps07

Copy link
Copy Markdown
Contributor Author

heyy @leandrodamascena pls review my pr and approve it. thanks!!

@leandrodamascena leandrodamascena added this to the 3.42.0 milestone Nov 15, 2026

@Manishram-ai Manishram-ai left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for picking this up. I compared the new models with the replication sample in the S3 docs, and all five fields line up. The example values for s3Operation and failureReason don't match what S3 sends, though, since the sample has codes there (OBJECT_PUT and AssumeRoleNotPermitted). I left suggestions for the examples and the fixture, and the parser tests (273), ruff and mypy pass with them.

Comment thread tests/events/s3EventReplication.json Resolved
@dropps07

Copy link
Copy Markdown
Contributor Author

Thanks @Manishram-ai for catching that, all four suggestions are applied now. The s3Operation and failureReason examples use the real S3 codes now, OBJECT_PUT and AssumeRoleNotPermitted, in the model examples, the record example, and the fixture. Parser tests, ruff and mypy all pass with them. Could you take another look when you get a chance?

@Manishram-ai Manishram-ai left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick update! The examples and the fixture match the S3 sample now, and the parser tests pass for me on the new commit.

@dropps07

Copy link
Copy Markdown
Contributor Author

Thanks @Manishram-ai for the review! If anything needs any changes or updates, please let me know. Looking forward to getting this approved. Thanks!

@leandrodamascena leandrodamascena left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @dropps07! Keeping every replication field optional is the right call, AWS only documents that payload for failed replications, and the models line up one to one with what we ship in the TypeScript parser. New fixture instead of touching the existing one, exactly as we ask. Goes out in 3.42.0, no need to rebase, you'll be in the release notes.

@dropps07

Copy link
Copy Markdown
Contributor Author

Thanks @dropps07! Keeping every replication field optional is the right call, AWS only documents that payload for failed replications, and the models line up one to one with what we ship in the TypeScript parser. New fixture instead of touching the existing one, exactly as we ask. Goes out in 3.42.0, no need to rebase, you'll be in the release notes.

superb!

@sonarqubecloud

Copy link
Copy Markdown

@leandrodamascena
leandrodamascena merged commit be21802 into aws-powertools:develop Nov 20, 2026
14 checks passed
@boring-cyborg

boring-cyborg Bot commented Nov 20, 2026

Copy link
Copy Markdown

Awesome work, congrats on your first merged pull request and thank you for helping improve everyone's experience!

@powertools-for-aws-oss-automation

Copy link
Copy Markdown

Awesome work, congrats on your first merged pull request and thank you for helping improve everyone's experience!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/L Denotes a PR that changes 100-499 lines, ignoring generated files. tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug: S3RecordModel drops lifecycleEventData and replicationEventData

3 participants